search

flathub / org.openscad.OpenSCAD

https://flathub.org/apps/details/org.openscad.OpenSCAD
0 stars 7 forks source link

Update OpenSCAD to 2019.05 (based on previous PR by @goncalossilva) #6

Closed Unrud closed 4 years ago

Unrud commented 4 years ago

Closes: #3 Closes: #4 Closes: #5

flathubbot commented 4 years ago

Started test build 12021

flathubbot commented 4 years ago

Build 12021 failed

flathubbot commented 4 years ago

Started test build 12023

t-paul commented 4 years ago

The errors on ARM are caused by Qt being compiled with GLES instead of Desktop-OpenGL. GLES is not supported by OpenSCAD.

flathubbot commented 4 years ago

Build 12023 failed

flathubbot commented 4 years ago

Started test build 12025

flathubbot commented 4 years ago

Build 12025 failed

flathubbot commented 4 years ago

Started test build 12026

flathubbot commented 4 years ago

Build 12026 failed

flathubbot commented 4 years ago

Started test build 12027

Unrud commented 4 years ago

The errors on ARM are caused by Qt being compiled with GLES instead of Desktop-OpenGL.

OK, the compilation of openscad itself on ARM failed in Build 12023 with OpenGL errors. I've removed the the commits that enable ARM.

flathubbot commented 4 years ago

Build 12027 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/11476/org.openscad.OpenSCAD.flatpakref
t-paul commented 4 years ago

Hello @cosimoc, are there other maintainers of that repo? I seem to have merge permission (after invitation by @barthalion) but I don't know much about flatpak as I'm not using it myself and I can't see if there's anyone else with permissions on this repo.

But if there's nobody else, I'm going to find out how things get updated. Thanks to the work of @goncalossilva and @Unrud the 2019.05 release is ready to be used and it would be a shame to leave that PR just lying around.

flathubbot commented 4 years ago

Queued test build for org.openscad.OpenSCAD.

flathubbot commented 4 years ago

Queued test build for org.openscad.OpenSCAD.

flathubbot commented 4 years ago

Started test build 13063

flathubbot commented 4 years ago

Started test build 13064

flathubbot commented 4 years ago

Build 13063 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/12461/org.openscad.OpenSCAD.flatpakref
flathubbot commented 4 years ago

Build 13064 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/12462/org.openscad.OpenSCAD.flatpakref
t-paul commented 4 years ago

@cosimoc thanks for the quick response. If you could help getting this update out, that would be awesome. I would prepare to take over for further updates (hoping to get a mostly patch/fix of OpenSCAD out soon). If you are able to still hang around and just keep an eye on things from time to time that would be much appreciated. At any rate, thanks for getting the flatpak packaging going.

cosimoc commented 4 years ago

@t-paul No worries!

I think the only outstanding comment is about icons. Since it looks like things have been improved upstream, with icons for all sizes, would it be possible to backport those icons (either as individual files or by backporting the relevant commits as patches) instead of building imagemagick and resizing during the build? That would be my preference, but otherwise this looks good.

flathubbot commented 4 years ago

Started test build 13086

Unrud commented 4 years ago

@cosimoc Added the new icons as sources.

flathubbot commented 4 years ago

Build 13086 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/12484/org.openscad.OpenSCAD.flatpakref
cosimoc commented 4 years ago

Tested the app and it works well. Thanks, I'm going to merge this.