search

flathub / org.openstreetmap.josm

https://flathub.org/apps/details/org.openstreetmap.josm
4 stars 3 forks source link

Add JavaFX and update the start script #60

Closed tsmock closed 2 years ago

tsmock commented 2 years ago

This replaces #58 and #59.

flathubbot commented 2 years ago

Started test build 97255

flathubbot commented 2 years ago

Build 97255 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/94981/org.openstreetmap.josm.flatpakref
muelli commented 2 years ago

thanks! Have you checked whether it works?

And does it make sense to have the JavaFX updated automatically if there is a newer version? If you, it would be nice if you added x-checker-data, but we can also file a bug to not forget about it and do it later.

tsmock commented 2 years ago

I was going to test it as soon as I got home last night. Rather unfortunately, it took some time for the builder to start. So I'll have to test tonight.

As far as JavaFX goes, I need to figure out a good way to get the latest version. The html checker would be a PITA to write, and could break at any time. If we used the git checker, we would have to deal with pre-release tags. I haven't seen an API for JavaFX yet (I've looked, but I may have missed it), so the JSON parser is out. Anitya seems to use the git repo, and doesn't see the difference between prerelease tags and release tags.

EDIT: I don't think the html checker is going to work. The web page uses JS to fill in data ("static HTML page" is required for the html checker).

EDIT2: To clarify, "Have you checked whether it works?" flatpak run org.openstreetmap.josm fails on my dev machine due to no display environment. It does actually start JOSM, I just cannot verify that it works properly.

which: no dpkg in (/usr/bin:/app/bin:/app/jre/bin)
Using /app/jre/bin/java to execute josm.
Can't open display
2022-06-23 06:38:05.534 INFO: Log level is at INFO (INFO, 800)
2022-06-23 06:38:06.026 SEVERE: Handled by bug report queue: java.awt.HeadlessException: No X11 DISPLAY variable was set,
but this program performed an operation which requires it.
java.awt.HeadlessException: 
No X11 DISPLAY variable was set,
but this program performed an operation which requires it.
    at java.desktop/java.awt.GraphicsEnvironment.checkHeadless(GraphicsEnvironment.java:166)
    at java.desktop/java.awt.Window.<init>(Window.java:553)
    at java.desktop/java.awt.Frame.<init>(Frame.java:428)
    at java.desktop/java.awt.Frame.<init>(Frame.java:393)
    at java.desktop/javax.swing.JFrame.<init>(JFrame.java:180)
    at org.openstreetmap.josm.gui.MainFrame.<init>(MainFrame.java:74)
    at org.openstreetmap.josm.gui.MainApplication.createMainFrame(MainApplication.java:999)
    at org.openstreetmap.josm.gui.MainApplication.mainJOSM(MainApplication.java:855)
    at org.openstreetmap.josm.gui.MainApplication$3.processArguments(MainApplication.java:282)
    at org.openstreetmap.josm.gui.MainApplication.main(MainApplication.java:742)

ReportedException [thread=Thread[main,5,], exception=java.awt.HeadlessException: 
No X11 DISPLAY variable was set,
but this program performed an operation which requires it., methodWarningFrom=BugReportExceptionHandler#handleException]
    at org.openstreetmap.josm.tools.bugreport.BugReport.intercept(BugReport.java:173)
    at org.openstreetmap.josm.tools.bugreport.BugReportExceptionHandler.handleException(BugReportExceptionHandler.java:22)
    at org.openstreetmap.josm.tools.bugreport.BugReportExceptionHandler.uncaughtException(BugReportExceptionHandler.java:14)
    at java.base/java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:1082)
    at java.base/java.lang.ThreadGroup.uncaughtException(ThreadGroup.java:1077)
    at java.base/java.lang.Thread.dispatchUncaughtException(Thread.java:2008)
Caused by: java.awt.HeadlessException: 
No X11 DISPLAY variable was set,
but this program performed an operation which requires it.
    at java.desktop/java.awt.GraphicsEnvironment.checkHeadless(GraphicsEnvironment.java:166)
    at java.desktop/java.awt.Window.<init>(Window.java:553)
    at java.desktop/java.awt.Frame.<init>(Frame.java:428)
    at java.desktop/java.awt.Frame.<init>(Frame.java:393)
    at java.desktop/javax.swing.JFrame.<init>(JFrame.java:180)
    at org.openstreetmap.josm.gui.MainFrame.<init>(MainFrame.java:74)
    at org.openstreetmap.josm.gui.MainApplication.createMainFrame(MainApplication.java:999)
    at org.openstreetmap.josm.gui.MainApplication.mainJOSM(MainApplication.java:855)
    at org.openstreetmap.josm.gui.MainApplication$3.processArguments(MainApplication.java:282)
    at org.openstreetmap.josm.gui.MainApplication.main(MainApplication.java:742)
flathubbot commented 2 years ago

Started test build 97325

flathubbot commented 2 years ago

Build 97325 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/95051/org.openstreetmap.josm.flatpakref
flathubbot commented 2 years ago

Started test build 97332

tsmock commented 2 years ago

I've got an autoupdate for JavaFX now. It is somewhat janky, so I would not be surprised if it breaks frequently. That is due to using anitya to check for git tags, which may not yet be released on gluonhq.

flathubbot commented 2 years ago

Build 97332 failed

flathubbot commented 2 years ago

Started test build 97389

tsmock commented 2 years ago

8ca406a73c6bd54393e8125f97228e251d61d7ca was tested and works.

flathubbot commented 2 years ago

Build 97389 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/95115/org.openstreetmap.josm.flatpakref