search

flathub / org.phoenicis.playonlinux

https://flathub.org/apps/details/org.phoenicis.playonlinux
4 stars 4 forks source link

Adding README.md as this app has additional extensions to be installed #1

Closed aiamuzz closed 5 years ago

aiamuzz commented 5 years ago

If you could get the flathub maintainers to add the additional 'Extension install command' before the 'Application Install command' ... it would help the users better, in fact the flathub application webpage is the right place for these instructions ... as not every user may find a need to visit the github page of the application.

flathubbot commented 5 years ago

NOTE: This comment was posted by the test instance of buildbot

Started test build 1502

flathubbot commented 5 years ago

NOTE: This comment was posted by the test instance of buildbot

Build 1502 successful To test this build, install it from the testing repository:

flatpak install --user http://repo-test.flathub.org:8080/build-repo/1426/org.phoenicis.playonlinux.flatpakref
flathubbot commented 5 years ago

NOTE: This comment was posted by the test instance of buildbot

Started test build 1515

flathubbot commented 5 years ago

NOTE: This comment was posted by the test instance of buildbot

Build 1515 successful To test this build, install it from the testing repository:

flatpak install --user http://repo-test.flathub.org:8080/build-repo/1439/org.phoenicis.playonlinux.flatpakref
flathubbot commented 5 years ago

NOTE: This comment was posted by the test instance of buildbot

Started test build 1516

flathubbot commented 5 years ago

NOTE: This comment was posted by the test instance of buildbot

Build 1516 successful To test this build, install it from the testing repository:

flatpak install --user http://repo-test.flathub.org:8080/build-repo/1440/org.phoenicis.playonlinux.flatpakref
flathubbot commented 5 years ago

NOTE: This comment was posted by the test instance of buildbot

Started test build 1520

flathubbot commented 5 years ago

NOTE: This comment was posted by the test instance of buildbot

Build 1520 successful To test this build, install it from the testing repository:

flatpak install --user http://repo-test.flathub.org:8080/build-repo/1444/org.phoenicis.playonlinux.flatpakref
flathubbot commented 5 years ago

NOTE: This comment was posted by the test instance of buildbot

Started test build 1529

flathubbot commented 5 years ago

NOTE: This comment was posted by the test instance of buildbot

Build 1529 successful To test this build, install it from the testing repository:

flatpak install --user http://repo-test.flathub.org:8080/build-repo/1452/org.phoenicis.playonlinux.flatpakref
aiamuzz commented 5 years ago

@alexlarsson ...

I was wondering if we had this type of readme infomation across all flathub application repo's ... I have added the website(flathub) link and the Runtime/Sdk info also there ... do you think it would be nice to have this info on all flathub application repo pages ?

If you give a nod ... i'll start publishing a README across all repo's one by one ...

PS : Lets end the issue of 'the space before the colon' here once and for all ... i don't want it to get anymore popular beyond this PR ... its hogging all the attention !!!

alexlarsson commented 5 years ago

I think that is up to each individual maintainer. Having such info in a readme is one more place it can go stale and one more place you have to update it. Also, it seems more likely that you end up on the flathub page rather than the github one if you google for the app.

flathubbot commented 5 years ago

NOTE: This comment was posted by the test instance of buildbot

Started test build 1531

flathubbot commented 5 years ago

NOTE: This comment was posted by the test instance of buildbot

Build 1531 successful To test this build, install it from the testing repository:

flatpak install --user http://repo-test.flathub.org:8080/build-repo/1454/org.phoenicis.playonlinux.flatpakref
aiamuzz commented 5 years ago

I think that is up to each individual maintainer. Having such info in a readme is one more place it can go stale and one more place you have to update it.

@alexlarsson ... hmmmmm ... never thought it that way makes sense though ...

Considering this then the runtime/sdk information is best left out ... as it would require to be updated ... so i have dropped it ...

The rest of the information in this commit ... is pretty much static ... requiring no update ... would you be fine to have this info on the flathub pages given its info about the app which otherwise is a blank page ?

Also, it seems more likely that you end up on the flathub page rather than the github one if you google for the app.

that would actually be good ... don't you think ... if a user was looking to install a flathub'd version of a particular app he SHOULD be directed to the 'flathub page' and not the github page ... a normal user would only want to install that app and that information is served at flathub with a better UI/UX ... github is more of a nerdy hangout ... if google directed people to flathub more then i'd say, so be it !

Also subject to your approval of this ... i thought i'd suggest that we consider adding the github page Link on the flathub application page ... that way even the nerds could redirect from there to github.

plata commented 5 years ago

@alexlarsson can we add the required extensions to the flathub page? If so, I would prefer if the README would only link there.

AsciiWolf commented 5 years ago

Any news?

plata commented 5 years ago

As you know, the help link will be pointing to our online documentation. Therefore I think it is sufficient to link to the flathub page here.

AsciiWolf commented 5 years ago

Not sure what changed, but it looks like the 32-bit Compat runtime is now automatically installed during PlayOnLinux installation.

$ flatpak --user install flathub org.phoenicis.playonlinux
Looking for matches…

org.phoenicis.playonlinux permissions:
    ipc            network              x11      devices
    multiarch      file access [1]

    [1] xdg-documents, xdg-download

        ID                                   Arch   Branch Remote  Download
 1.     org.phoenicis.playonlinux            x86_64 stable flathub < 110.7 MB
 2.     org.freedesktop.Platform.Compat.i386 x86_64 18.08  flathub < 177.8 MB

Proceed with these changes to the user installation? [Y/n]:

I am using Flatpak 1.2.4 on Fedora 29.

plata commented 5 years ago

Ok, that's interesting. We didn't change anything from our side, so this must be something in flatpak. I didn't follow the flatpak changes closely therefore I'm not aware what might have changed. In any case, this probably means that this PR can be closed, right?

AsciiWolf commented 5 years ago

Yep, seems to be ok to close this PR. :)