flathub / org.prismlauncher.PrismLauncher

https://flathub.org/apps/details/org.prismlauncher.PrismLauncher
8 stars 12 forks source link

Remove seemingly unnecessary, '--device=all' in favor of '--device=dri' #20

Closed gerblesh closed 1 year ago

gerblesh commented 1 year ago

It seems a bit excessive to have full device access when only access to the GPU is needed. Don't know exactly if this breaks anything , but prismlauncher launches fine, plays fine, and behaves as before with these changes from what i've seen/played myself

flathubbot commented 1 year ago

Started test build 45803

flathubbot commented 1 year ago

Build 45803 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/28423/org.prismlauncher.PrismLauncher.flatpakref
gerblesh commented 1 year ago

closed this PR because I realized that it was running through software rendering, not hardware, feeling pretty dumb now

flathubbot commented 1 year ago

Started test build 45808

gerblesh commented 1 year ago

Strange. It seems to work now with GPU with only device=dri, I'll leave this open for now then

flathubbot commented 1 year ago

Build 45808 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/28428/org.prismlauncher.PrismLauncher.flatpakref
Scrumplex commented 1 year ago

device=all is needed for controller/gamepad support. Especially important on devices like the Steam Deck

gerblesh commented 1 year ago

makes sense, i figured there was a catch of some sort, i'll close this PR then