search

flathub / org.pwsafe.pwsafe

https://flathub.org/apps/details/org.pwsafe.pwsafe
0 stars 3 forks source link

Yubikey not supported in flatpak Password Safe v1.18.2 #4

Closed igor2x closed 3 months ago

igor2x commented 8 months ago

Installed Password Safe 1.18.2 as flatpak from Flathub on Ubuntu 23.10. From menu Manage there is no "YubiKey" entry like it is on deb package.

ronys commented 8 months ago

Odd. That looks like NO_YUBI was defined (by setting -DNO_YUBI=ON) ??

igor2x commented 8 months ago

In manifest file the only current options are:

config-opts:
  - -DNO_GTEST=ON
  - -DGTEST_BUILD=OFF

Both of them are options to not perform tests, because I have had no idea how to include all of this tests in build system and I imagined if tests are run using deb/rpm, there is probably no need to rerun them using flatpak.

But you see there is no -DNO_YUBI=ON option.

nobugshere commented 7 months ago

I think cmake defined NO_YUBI because the libs are not present in the standard runtime. I've submitted PR #9 for this issue.

nobugshere commented 3 months ago

Yubikey now works, as of 1.19.1. PR #9