flathub / org.qbittorrent.qBittorrent

https://flathub.org/apps/details/org.qbittorrent.qBittorrent
9 stars 12 forks source link

Update QT Version #112

Closed iMonZ closed 1 year ago

flathubbot commented 1 year ago

Started test build 25000

flathubbot commented 1 year ago

Build 25000 failed

iMonZ commented 1 year ago

This tool should work with QT6. But somehow it doesn't build. Can someone help me with that?

* STACKTRACE, Enable stacktrace support (default: ON)
 * DBUS, Enable support for notifications and power-management features via D-Bus on Linux (default: ON; depends on condition: GUI)
-- The following features have been disabled:
 * QT6, Build with Qt 6 instead of Qt 5 (default: OFF)
 * TESTING, Build internal testing suite (default: OFF)
 * VERBOSE_CONFIGURE, Show information about PACKAGES_FOUND and PACKAGES_NOT_FOUND in the configure output (only useful for debugging the CMake build scripts) (default: OFF)
 * SYSTEMD, Install systemd service file. Target directory is overridable with `SYSTEMD_SERVICES_INSTALL_DIR` variable (default: OFF; depends on condition: NOT GUI)
-- Performing Test Iconv_IS_BUILT_IN
-- Performing Test Iconv_IS_BUILT_IN - Success
-- Found OpenSSL: /usr/lib/x86_64-linux-gnu/libcrypto.so (found suitable version "3.0.7", minimum required is "1.1.1")  
-- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found suitable version "1.2.12", minimum required is "1.2.11") 
CMake Error at cmake/Modules/CheckPackages.cmake:59 (find_package):
  By not providing "FindQt5.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "Qt5", but
  CMake did not find one.
  Could not find a package configuration file provided by "Qt5" (requested
  version 5.15.2) with any of the following names:
    Qt5Config.cmake
    qt5-config.cmake
  Add the installation prefix of "Qt5" to CMAKE_PREFIX_PATH or set "Qt5_DIR"
  to a directory containing one of the above files.  If "Qt5" provides a
  separate development package or SDK, be sure it has been installed.
Call Stack (most recent call first):
  CMakeLists.txt:53 (include)
-- Configuring incomplete, errors occurred!
See also "/run/build/qbittorrent/_flatpak_build/CMakeFiles/CMakeOutput.log".
FB: host_command_exited_cb 3716984 256
]2;flatpak-builder: Cleanup qbittorrentError: module qbittorrent: Child process exited with code 1
FB: Unmounting read-only fs: fusermount -uz /srv/buildbot/worker/build-x86_64/build/.flatpak-builder/rofiles/rofiles-F70nvb
program finished with exit code 1
elapsedTime=158.173390
flathubbot commented 1 year ago

Started test build 25006

flathubbot commented 1 year ago

Build 25006 failed

Chocobo1 commented 1 year ago

@iMonZ I've met a regression with Qt 6.2 in the past I wonder if it has been resolved in Qt 6.4? https://github.com/flathub/org.qbittorrent.qBittorrent/pull/84#issuecomment-1193242265 (opening that dialog was slow and scrolling up/down the file list was slow too)

flathubbot commented 1 year ago

Started test build 25117

flathubbot commented 1 year ago

Build 25117 failed

flathubbot commented 1 year ago

Started test build 25132

flathubbot commented 1 year ago

Build 25132 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/7779/org.qbittorrent.qBittorrent.flatpakref
flathubbot commented 1 year ago

Started test build 25133

iMonZ commented 1 year ago

I testet it out. It works and can be merged into master :)

Thanks @pm4rcin !

flathubbot commented 1 year ago

Build 25133 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/7780/org.qbittorrent.qBittorrent.flatpakref
iMonZ commented 1 year ago

@Chocobo1 Can you merge it please :)

Chocobo1 commented 1 year ago

@Chocobo1 Can you merge it please :)

Not until all regressions are resolved. I briefly tested it and still ran into this problem https://github.com/flathub/org.qbittorrent.qBittorrent/pull/112#issuecomment-1445273534 Also I need confirmation that this theme issue is gone: https://github.com/flathub/org.qbittorrent.qBittorrent/pull/90#issuecomment-1242794147

For the time being, I would rather adopt Erick555 suggestion to move Qt6 to the beta branch. And bump the stable branch to 5-15-22.08.

iMonZ commented 1 year ago

90 (comment)

Sorry for missing that comment. Let me check both issues. I let you know

Chocobo1 commented 1 year ago

90 (comment)

Sorry for missing that comment. Let me check both issues. I let you know

@iMonZ Any news?

I've already updated beta branch to Qt 6.4, so I'll be closing this.