search

flathub / org.scummvm.ScummVM

https://flathub.org/apps/details/org.scummvm.ScummVM
3 stars 5 forks source link

Enable all engines #20

Closed FakeShemp closed 2 years ago

FakeShemp commented 2 years ago

Is there a reason for the flatpak build to not include all engines?

Right now I'm getting Escape from Monkey Island support is not compiled in when trying to run it, but it is detected fine in the GUI.

AsciiWolf commented 2 years ago

I remember that some of them were disabled because the dependencies were too complicated to get working in the Flatpak build, but I did not notice that games like Escape from Monkey Island were disabled as well. Thanks for reporting this! I will try fixing it when I have some time.

lotharsm commented 2 years ago

Hey there!

For the stable releases, we at ScummVM explicitly disable the unstable engines for official releases because only the really stable ones should be in there. Currently, this evolves Escape from Monkey Island because the game still has some bugs left impacting gameplay.

Thus, from an "upstream perspective", I recommend following this procedure and build ScummVM with the --enable-release flag which disables the unstable engines. The behaviour of the FlatPak will then follow our official builds.

AsciiWolf commented 2 years ago

Hi Lothar, thanks for the comment! I see that we already use the --enable-release flag, so I suppose this ticket could be closed? :-)

lotharsm commented 2 years ago

Yes, if you want to stay as close to our guidelines as possible and basically making the FlatPak an "official" release, this ticket should be closed indeed. 🙂

AsciiWolf commented 2 years ago

Ok. :-) By the way, feel free to let me know if you are interested in push rights to this repo.