Closed prodrigestivill closed 11 months ago
Started test build 31757
Build 31757 successful To test this build, install it from the testing repository:
flatpak install --user https://dl.flathub.org/build-repo/14410/org.scummvm.ScummVM.flatpakref
Started test build 31849
Build 31849 successful To test this build, install it from the testing repository:
flatpak install --user https://dl.flathub.org/build-repo/14500/org.scummvm.ScummVM.flatpakref
Started test build 63936
Build 63936 failed
Started test build 63939
Build 63939 failed
Thanks! I will be happy to merge this after the build issues are resolved.
Started test build 64057
Build 64057 successful To test this build, install it from the testing repository:
flatpak install --user https://dl.flathub.org/build-repo/46692/org.scummvm.ScummVM.flatpakref
Started test build 64058
Build 64058 successful To test this build, install it from the testing repository:
flatpak install --user https://dl.flathub.org/build-repo/46693/org.scummvm.ScummVM.flatpakref
Thanks again! I will review and merge this PR tomorrow. :-)
Looks good!
As a proposal I performed this changes:
shared-modules
one and updated theshared-modules
to the latest commit.x-checker-data
to the rest of flatpak modules so FlathubBot can create automatic pull requests.Note that in order to allow FlathubBot to automatically merge its own PRs (if they succeed) it is required to add the file
flathub.json
with:If you want I can also add this in this PR, or you can add it later in a separated PR.
Also now flatpak supports both JSON and YAML, if you prefer to switch the manifest to YAML I can add another commit with that, both are ok for me, whatever suits best for you.