flathub / org.scummvm.ScummVM

https://flathub.org/apps/details/org.scummvm.ScummVM
3 stars 5 forks source link

Give ScummVM full home dir access #42

Closed AsciiWolf closed 7 months ago

AsciiWolf commented 8 months ago

This will make the ScummVM Flatpak less sandboxed, but will make it much more straightforward to use for end-users without forcing them to copy the game files into xdg-documents.

ScummVM config and save files will continue to stay inside the Flatpak app directory since ScummVM already supports XDG base directories for this, so there will be no breakage for existing users.

Also, the ScummVM 2.8.0 Flatpak no longer mentions the sandbox limitation in its AppStream metadata (since it uses the upstream version of the metainfo file instead of a bundled downstream one).

@lotharsm Is this ok to be merged (after it gets tested)?

flathubbot commented 8 months ago

Started test build 90718

AsciiWolf commented 8 months ago

https://github.com/flathub/org.scummvm.ScummVM/blob/master/scummvm_wrapper/scummvm_wrapper.py#L13

Let's see if this still works fine after the file system permissions change. :)

lotharsm commented 8 months ago

Yep, thank you, this is a real useful addition. For ScummVM itself, there's no reason to keep it confined within the documents and pictures folders.

+1 from me.

AsciiWolf commented 8 months ago

Thanks! If I remember correctly, there used to be a problem (Flatpak limitation) when setting full access to the user's home directory also moved all the application configuration files there. However, this is no longer the case for applications such as ScummVM, which support standard XDG directories. :)

flathubbot commented 7 months ago

Build 90718 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/73400/org.scummvm.ScummVM.flatpakref
AsciiWolf commented 7 months ago

Tested and everything seems to work fine. :-)