Rework wayland logic by using `ELECTRON_OZONE_PLATFORM_HINT` environment variable

[flathubbot]

Started test build 99593

[flathubbot]

Build 99593 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82384/org.signal.Signal.flatpakref

[flathubbot]

Started test build 99839

[flathubbot]

Started test build 99846

[flathubbot]

Build 99839 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82634/org.signal.Signal.flatpakref

[flathubbot]

Build 99846 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/82641/org.signal.Signal.flatpakref

[flathubbot]

Started test build 101697

[flathubbot]

Build 101697 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/84486/org.signal.Signal.flatpakref

[flathubbot]

Started test build 103056

[xduugu]

Rebased against master

[flathubbot]

Build 103056 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/85839/org.signal.Signal.flatpakref

[pm4rcin]

@bermeitinger-b it would be great to merge this after rebase since it would allow setting global env variable for flatpak apps that people on wayland could use until chrome enables it by default.

[bermeitinger-b]

Thanks. Could you rebase again?

I guess that it should also be able to remove both x11 and wayland sockets and use x11 as fallback. We tried this a while back and electron was not working.

[pm4rcin]

If @xduugu won't rebase it for a few days I'll create a PR.

[xduugu]

Rebased again, @bermeitinger-b.

[bermeitinger-b]

bot, build

[flathubbot]

Queued test build for org.signal.Signal.

[flathubbot]

Started test build 132570

[flathubbot]

Build 132570 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/115575/org.signal.Signal.flatpakref

[bermeitinger-b]

Do we need to expose the variable in the yml file?

[pm4rcin]

Do we need to expose the variable in the yml file?

I don't think so since IMO it's supposed to be global override for all Electron apps by default. If someone changes flatseal permissions he probably understands what he does.

[bermeitinger-b]

Thank you.

Would have been a good choice to use the beta branch. But let's see what happens.

[pm4rcin]

@bermeitinger-b we forgot to try adding fallback-x11 to make linter happy. But someone on X11 would have to test.

[bermeitinger-b]

We can try another PR for this. X11 never had any problem with any setting. It always was Wayland.

[pm4rcin]

We can try another PR for this. X11 never had any problem with any setting. It always was Wayland.

Good to know, I didn't remember that from a few months ago. I'll create PR soon.

[pm4rcin]

@bermeitinger-b from what I can see it was related to input methods not working with wayland. I've tried checking the upstream electron issue on this and I feel like it's probably not ready yet. There were some successes on Chrome but I don't think it will work with electron. Should we try anyway?

[bermeitinger-b]

From the past tries, when we made the linter happy, numerous issues with Wayland arose. From my understanding, the fallback to Xwayland let's it run. I tried in a Fedora VM and could remove the X11 socket, however, this small test might not be sufficient for every case out there.

How about a PR and we'll wait for merging?