Show encryption notification only once

[bermeitinger-b]

Show the encryption warning only once.

[flathubbot]

Started test build 150002

[flathubbot]

Build 150002 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/133093/org.signal.Signal.flatpakref

[bb010g]

Script is still inconsistent between gnome_libsecret and gnome-libsecret.

[flathubbot]

Started test build 150012

[bermeitinger-b]

Always showing the warning when basic is selected seems out of scope for us. This should be an upstream discussion.

[minosimo]

It is not necessary to warn all users that we are using the unencrypted key store when the application has already been doing so for a long time.

The warning should appear:

• When launching Signal for the first time after a new install
• On an existing install, if the user switches from a system keystore to the basic keystore

[flathubbot]

Build 150012 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/133103/org.signal.Signal.flatpakref

[bbhtt]

It is not necessary to warn all users that we are using the unencrypted key store when the application has already been doing so for a long time.

The difference is previously the official package didn't support it and official builds used plaintext as well. Now the official ones don't do anymore

This makes Flatpak a worse option for some people. Users should be aware of that, new or old both and choose what's best for them.

[bermeitinger-b]

On an existing install, if the user switches from a system keystore to the basic keystore

This will never be intentional, right? Why would they change a running system and intentially lessen the security. It could happen, if they somehow reset the env var to default. But then, the warning is useless because Signal will complain anyway.

Is there a nice way to check if this is the first install? Then do this instead of the warning_shown file.

The difference is previously the native package didn't support it and official builds used plaintext as well. Now the official ones don't do anymore

They fallback to basic just as we do here. Apparently, the implementation is a bit broken, so it (Chromium, Electron, and/or Signal) can't find the backend correctly. This database error is not exclusive to flatpak.

[minosimo]

On an existing install, if the user switches from a system keystore to the basic keystore This will never be intentional, right? Why would they change a running system and intentially lessen the security. It could happen, if they somehow reset the env var to default. But then, the warning is useless because Signal will complain anyway.

Is there a nice way to check if this is the first install? Then do this instead of the warning_shown file.

The difference is previously the native package didn't support it and official builds used plaintext as well. Now the official ones don't do anymore They fallback to basic just as we do here. Apparently, the implementation is a bit broken, so it can't find the correct backend correctly. This database error is not exclusive to flatpak.

config.json, among others, are generated on first launch.

[bbhtt]

if it's broken on official ones as well you could use the first install idea, just check if the config folder or some file in it exists.

On first install it won't exist unless signal is executed which is at the very last line of the script.

[flathubbot]

Started test build 150015

[bermeitinger-b]

This will only warn upon the first run. (However, we differ here from upstream.)

Also, this is generally a workaround, The secrets portal should provide the correct backend name by its run.

[flathubbot]

Build 150015 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/133106/org.signal.Signal.flatpakref

[flathubbot]

Started test build 150017

[bbhtt]

You can drop the else condition that touch es the file in lines 26-28

[flathubbot]

Build 150017 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/133108/org.signal.Signal.flatpakref

[flathubbot]

Started test build 150018

[flathubbot]

Build 150018 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/133109/org.signal.Signal.flatpakref