Spec for 3.28

[hbons]

Notable changes:

• Convert spec to YAML
• Add dependencies for Ubuntu's AppIndicator
• Compile an optimised Git for bundling from source
• The build now includes the appdata file with screenshots
• Build with Meson

[hbons]

bot, build

[hbons]

bot, build

[nedrichards]

Could you add OARS to the upstream appdata? Not a blocker but it's now a flathub requirement and we'd love to fixup all the apps that got in early.

[hbons]

will do!

[hbons]

I've added this in master. Are the ratings needed right now? I don't want to create a new release just for that, but I can make a patch for the spec.

[nedrichards]

Not needed right now, happy to wait until the next release if that's sooner than six months.

On Mon, 16 Jul 2018, 17:43 Hylke Bons, notifications@github.com wrote:

I've added this in master. Are the ratings needed right now? I don't want to create a new release just for that, but I can make a patch for the spec.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/flathub/org.sparkleshare.SparkleShare/pull/4#issuecomment-405310316, or mute the thread https://github.com/notifications/unsubscribe-auth/AASeVR8yFiT7xezILrY7Fd6zp5MZin58ks5uHMLEgaJpZM4VP-b7 .

[hbons]

Ok! Definitely in the next six months. I'm syncing to the GNOME release schedule now (hence the version number change to match).

[hbons]

so is this good to be merged? :)

[hbons]

bot, build

[hbons]

@nedrichards any clue why it doesn’t build?

[barthalion]

What if you skip the quotation marks?

[barthalion]

It's actually simpler, somehow submodule has not been added correctly, try to clone the repo with --recursive --branch 3.28 to see it locally.

[nedrichards]

I'll check out the branch and have a look. It's absolutely something to do with the submodule.

[nedrichards]

bot, build

[hbons]

thanks!