flathub / org.standardnotes.standardnotes

https://flathub.org/apps/details/org.standardnotes.standardnotes
2 stars 4 forks source link

Backups Don't Work #448

Open DarkArc opened 9 months ago

DarkArc commented 9 months ago

The Standard Notes Backups feature doesn't seem to work, it ends up mapping to something like /run/user/1000/doc/bla bla bla rather than the selected folder.

DarkArc commented 9 months ago

Giving increased file system access (vs the flatpak defaults) doesn't seem to resolve the issue.

Generally though, it seems like having access to user files/the home directory would make the most sense so the app has access to write backups anywhere the user (reasonably) selects.

salad612 commented 7 months ago

I think, instead of creating the Documents and Standard Notes Backups folder in the sandbox, the app should be given access to ~/Documents/standardnotes:create and ~/Standard Notes Backups:create directly. I disagree on giving access to the whole home directory though, I don't think the sandbox should be broken for a setting that most users won't change from the default.

proletarius101 commented 7 months ago

To my understanding, the directory names of the backups are different by accounts. It's almost impossible to just grant a fine-grained file system access.

On the other hand, if you choose a custom location, the access will be automatically granted.

salad612 commented 7 months ago

To my understanding, the directory names of the backups are different by accounts. It's almost impossible to just grant a fine-grained file system access.

On the other hand, if you choose a custom location, the access will be automatically granted.

But that directory is INSIDE the Documents/standardnotes folder, right? If you grant access to that folder, I believe it should work. Although, I did not test this myself.

As for the custom location, the portal doesn't seem to work properly for whatever reason. CHOOSING a location works, but when you actually make the backup or press open folder it results in what OP got, some /run/user/1000/ whatever.

DarkArc commented 7 months ago

I disagree on giving access to the whole home directory though, I don't think the sandbox should be broken for a setting that most users won't change from the default.

I think being pedantic about the app's sandbox surface area is not particularly useful.

The app has a feature to allow the user to put backups wherever they like. I don't think it's a reasonable thing to assume that most people (or even an insignificant percentage of people) would like to change this location.

Also remember, this is an open source and audited app; not some random proprietary blob that's likely to be untrustworthy.

As for the custom location, the portal doesn't seem to work properly for whatever reason. CHOOSING a location works, but when you actually make the backup or press open folder it results in what OP got, some /run/user/1000/ whatever.

Yes, this.

It's worth noting this used to work.