flathub / org.strawberrymusicplayer.strawberry

https://flathub.org/apps/details/org.strawberrymusicplayer.strawberry
1 stars 4 forks source link

No audio CD support? #22

Closed oseez closed 2 years ago

oseez commented 2 years ago

Libcdio was compiled to disable CD access? A music player intentionally unable to play CDs?!

Lunarequest commented 2 years ago

It was built with those flags to prevent it from attempting to pass udev rules which isn't possible in the flatpak environment. Other wise it works as intended. I've actually played a few audio CDs myself to confirm

Lunarequest commented 2 years ago

I'd also like to point out Clementine also does this here https://github.com/flathub/org.clementine_player.Clementine/blob/master/org.clementine_player.Clementine.yaml#L87-L96

jonaski commented 2 years ago

Those options doesn't disable CD access, they only disable building utilities, only the library is used by strawberry which is built even with all the --without options:

  --without-cd-drive      don't build program cd-drive (default with)
  --without-cd-info       don't build program cd-info (default with)
  --without-cdda-player   don't build program cdda-player (default with)
  --without-cd-read       don't build program cd-read (default with)
  --without-iso-info      don't build program iso-info (default with)
  --without-iso-read      don't build program iso-read (default with)