search

flathub / org.wesnoth.Wesnoth

https://flathub.org/apps/details/org.wesnoth.Wesnoth
3 stars 3 forks source link

Current package fails to build #11

Closed hfiguiere closed 5 years ago

hfiguiere commented 5 years ago

The current package fails to build because of appdata validation.

It's missing the oars tag and releases.

This blocks issue #10.

loonycyborg commented 5 years ago

I figured out how to add oars entry, but I have no idea how best to maintain <releases> tag. Need to somehow autogenerate it from git tags I guess? If I just fill it manually it's nearly guaranteed that it'll become outdated sooner or later. Probably sooner. I'd prefer if <releases> requirement didn't exist. Is it actually used somewhere for something?

hfiguiere commented 5 years ago

I do it manually by summarizing the release note.

loonycyborg commented 5 years ago

Honestly, previously I just did a version bump in JSON file and then a commit. I'm kinda unwilling to give up this simple workflow. I don't want to have to edit the xml file for each release. Unless release managers are willing to update appdata file themselves I would have to add new <release> tag in a patch against appdata file that is already provided upstream. Either that or fill it with bogus data that pass validation. Although I have commit access to upstream repo, another person does the tagging and I start packaging work already after that.

hfiguiere commented 5 years ago

You could upstream this so that upstream can be convinced to help more easily. It doesn't need a lot of information.

loonycyborg commented 5 years ago

Well it's totally fine to fill it in once but <release> field needs adding for each release with only two mandatory fields: version and date which don't require manual input to figure out, so it's most definitely something that should be automated.

hfiguiere commented 5 years ago

Still fails. you forgot OARS in the flatpak

loonycyborg commented 5 years ago

Added it now