Alternative Implementation for #155

[czhang03]

This PR does not harden any permission by default, it only makes hardening the permission easier. The "hardened by default" approach is implemented in #155 .

By default, this PR grants zotero permission to the user home dir, which is the same as current default; thus this change do not break any functionality, including drag and drop, and makes the zotero folder in the default location (~/.zotero and ~/Zotero).

Changes:

• Added documentation about removing the home dir permission.
• Added persistent folders so that zotero folder is automatically sandboxed once the user home permission is removed.

[flathubbot]

Started test build 110322

[flathubbot]

Build 110322 failed

[flathubbot]

Started test build 110326

[flathubbot]

Build 110326 failed

[flathubbot]

Started test build 110327

[flathubbot]

Build 110327 failed

[flathubbot]

Started test build 110328

[flathubbot]

Build 110328 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/93152/org.zotero.Zotero.flatpakref

[flathubbot]

Started test build 110717

[flathubbot]

Build 110717 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/93536/org.zotero.Zotero.flatpakref

[flathubbot]

Started test build 110721

[flathubbot]

Build 110721 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/93540/org.zotero.Zotero.flatpakref

[flathubbot]

Started test build 110731

[flathubbot]

Build 110731 failed

[czhang03]

Hi, I have implemented the change, and added back the xdg-dir permissions. This makes the command line for to remove all file system permission too complicated to include in the app description.

I can add a readme file to the repo to detail such command.

Also, I personally am concerned about too much command in flathub app description, as flathub do not specifically target developers, adding too much command might give "you need to use command line to use linux" vibe. On the other hand, I believe command line is probably best included in readme files on GitHub repos.

[flathubbot]

Started test build 110756

[flathubbot]

Build 110756 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/93574/org.zotero.Zotero.flatpakref

[sebastian-de]

Hi, I have implemented the change, and added back the xdg-dir permissions. This makes the command line for to remove all file system permission too complicated to include in the app description.

I think it's worth a try to remove the xdg-* permissions (at least for testing in the beta branch) like you did in your initial version of this PR. We still keep the home permission by default, so I guess this will cover the majority of users. And with portal support even those who have XDG dirs outside of their home directories will probably have all the functionality they need.

And a handy git tip: You can use git commit --amend to edit your current commit and force-push it afterwards - that way you don't have to create a commit for every small change. But multiple commits are okay too - they'll be squashed before being merged.

[flathubbot]

Started test build 111650

[flathubbot]

Build 111650 failed

[flathubbot]

Started test build 111653

[flathubbot]

Build 111653 failed

[flathubbot]

Started test build 111657

[flathubbot]

Build 111657 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/94472/org.zotero.Zotero.flatpakref

[sebastian-de]

The forum post is here: https://forums.zotero.org/discussion/113336/beta-testing-zotero-7-flatpak

Feel free to add anything I may have forgotten 😉

[czhang03]

Thank you so much! That is a great post!

I should link the original issue #154 from here, so that people reading that issue can find the implementation here.