search

flathub / org.zotero.Zotero

https://flathub.org/apps/details/org.zotero.Zotero
20 stars 15 forks source link

WIP : Add zotero URI handling #87

Closed lionirdeadman closed 2 years ago

lionirdeadman commented 3 years ago

Fix #64

flathubbot commented 3 years ago

Started test build 48924

flathubbot commented 3 years ago

Build 48924 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/47061/org.zotero.Zotero.flatpakref
flathubbot commented 3 years ago

Started test build 48958

flathubbot commented 3 years ago

Build 48958 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/47094/org.zotero.Zotero.flatpakref
felipehw commented 3 years ago

It works?

lionirdeadman commented 3 years ago

No, it seems that while it opens the program, for some reason the application doesn't open the file that the link points to.

felipehw commented 3 years ago

:(

pbsds commented 3 years ago

I think the Exec entry in the .desktop file is missing -url %U. Example: https://aur.archlinux.org/cgit/aur.git/tree/zotero.desktop?h=zotero

Documentation of the field: https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s07.html

wshanks commented 2 years ago

I made @pbsds's suggestion an inline comment suggestion. With that, select item links work for me.

felipehw commented 2 years ago

Many thanks for fixing this issue.

I don't know how to add the build.sh changes here (neither how to incorporate the suggestions of @wshanks).

So, I'm doing a new one with the original changes at org.zotero.Zotero.json and the needed changes at build.sh: https://github.com/flathub/org.zotero.Zotero/pull/91.

Please, let's always update the build.sh instead directly the org.zotero.Zotero.json and org.zotero.Zotero.appdata.xml. This helps to keep the Zotero Flatpak updated with minimal efforts.

wshanks commented 2 years ago

Sorry, I missed the build.sh. By the way, for keeping the flatpak updated, you might look at https://github.com/flathub/flatpak-external-data-checker. I use it on the flatpak I maintain and it has worked well (the x-data-checker entries in this yaml).