flathub / org.zotero.Zotero

https://flathub.org/apps/details/org.zotero.Zotero
20 stars 15 forks source link

Update to Zotero 6.0 #95

Closed m8 closed 2 years ago

m8 commented 2 years ago

Hi, zotero updated to 6.0 (https://github.com/flathub/org.zotero.Zotero/issues/94). It's my first pr to flathub, so if there is something wrong let me know, Thanks!

flathubbot commented 2 years ago

Started test build 82178

flathubbot commented 2 years ago

Build 82178 failed

LyzardKing commented 2 years ago

~~There seems to be an issue in reading the .desktop file, specifically the SingleMainWindow entry. This could be an issue with flatpak, since that entry is in the spec (https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html)~~

A flag has changed in the .desktop file that requires the version to be set to 1.5. I opened a PR on the zotero github at https://github.com/zotero/zotero-standalone-build/pull/94

felipehw commented 2 years ago

@LyzardKing

Your observations are correct. While we wait for the upstream to do these changes in the desktop entry, I made the needed changes in the Flatpak desktop entry file.

Could you test this Flatpak to see if you find any problem?

https://github.com/flathub/org.zotero.Zotero/pull/97#issuecomment-1072499901

By the way, please, make the changes in the build.sh script (that generates the final files) to help avoid maintenance in the future 😉

Thanks for your help :D

LyzardKing commented 2 years ago

@felipehw This is now changed upstream. The flatpak can be rebuilt without the change