search

flathub / org.zulip.Zulip

https://flathub.org/apps/details/org.zulip.Zulip
2 stars 6 forks source link

Add hack to make the tray icon work #22

Closed lazka closed 4 years ago

lazka commented 4 years ago

See #18

flathubbot commented 4 years ago

Started test build 19696

lazka commented 4 years ago

@TingPing could you maybe weigh in on whether this is acceptable or if you know any alternatives (this is an electron app built from source if that helps)

See https://github.com/flathub/org.zulip.Zulip/pull/20#issuecomment-625742977 for @ghisvail wishing more discussion on this.

flathubbot commented 4 years ago

Build 19696 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/18901/org.zulip.Zulip.flatpakref
hstock commented 4 years ago

I am on cinnamon on Debian 10. This build does not show an icon either. However, a very small empty space is created in the appindicators area which can be clicked. So the icon is "invisible and very small".

Seems to be related to this: https://github.com/electron/electron/issues/21445

lazka commented 4 years ago

Thanks. I've only tested under GNOME so far, where things look fine.

81339510-982cbf00-90ae-11ea-868e-d93a956fec88

lazka commented 4 years ago

Looks like this is fixed, so closing. Thanks @ghisvail !