search

flathub / re.rizin.cutter

https://flathub.org/apps/details/re.rizin.cutter
1 stars 1 forks source link

Consider dropping --filesystem=home permission #5

Open koko-ng opened 1 year ago

koko-ng commented 1 year ago

Hi! Thanks a lot for the packaging, it's very convenient :)

Since you first published it, the KDE desktop portal now supports complete filesystem accesses, therefore the permission is now longer required. I tried without it and it seems to work flawlessly! Do you think there are edge cases where it could cause a problem? Otherwise I think it's safe to remove it.

Best

0pendev commented 1 year ago

Thanks for the feedback. I'll try to see if wlroots and gnome portals have the same behaviour

koko-ng commented 1 year ago

Oh I might not have expressed myself correctly, the Qt library supports calling the portal. I tested using GNOME.

Sorry for the misunderstanding

0pendev commented 1 year ago

@koko-ng on what os did you test this ? I'm running an opensuse tumbleweed and wanted to test this on older software as weel but I don't have a VM set up. Curious to see what you use because it could save me some testing time

0pendev commented 1 year ago

Also, even though I'll be dropping the home permission, I'll see how to add a permission for the user configuration/plugins directory

koko-ng commented 1 year ago

on what os did you test this ?

Fedora Silverblue 38 with GNOME 44, so also the most recent version, sorry.

Also, even though I'll be dropping the home permission, I'll see how to add a permission for the user configuration/plugins directory

Not sure it is even necessary, on my install with or without the home permission they are set to ~/.var/app/re.rizin.cutter/config/rizin/cutter and ~/.var/app/re.rizin.cutter/data/rizin/cutter/plugins which both are available without the home permission, my guess would be that they are set from the XDG base directories anyway.

0pendev commented 1 year ago

on what os did you test this ?

Fedora Silverblue 38 with GNOME 44, so also the most recent version, sorry.

No worries. I'm going to set up an old debian machine to see if it works then.

Also, even though I'll be dropping the home permission, I'll see how to add a permission for the user configuration/plugins directory

Not sure it is even necessary, on my install with or without the home permission they are set to ~/.var/app/re.rizin.cutter/config/rizin/cutter and ~/.var/app/re.rizin.cutter/data/rizin/cutter/plugins which both are available without the home permission, my guess would be that they are set from the XDG base directories anyway.

Yeah it's true, and it's shown in the plugin window in Cutter so I guess we can drop the permission if it works fine on older OS. I'll try to close this issue this week