search

flathub / rocks.koreader.KOReader

https://flathub.org/apps/details/rocks.koreader.KOReader
1 stars 2 forks source link

Please remove usages of branch property from manifests #29

Closed bbhtt closed 5 months ago

bbhtt commented 5 months ago

https://github.com/flathub/rocks.koreader.KOReader/blob/3282118c23b4eaa2d4268eb6829c88c92c25e675/rocks.koreader.KOReader.yml#L107

should be tag or commit or tag+commit

Frenzie commented 5 months ago

Pinging @proletarius101. Branch, tag, and commit are all guaranteed to require future manual intervention. Would there be a way to make it "the commit the relevant tag from the main repo refers to"?

PS I was really confused at first due to the lack of context. :-)

https://github.com/flathub/rocks.koreader.KOReader/blob/3282118c23b4eaa2d4268eb6829c88c92c25e675/rocks.koreader.KOReader.yml#L105-L109

proletarius101 commented 5 months ago

Branch, tag, and commit are all guaranteed to require future manual intervention.

What kind of intervention?

Frenzie commented 5 months ago

What kind of intervention?

Do you mean the commit hash will in fact be updated automatically?

proletarius101 commented 5 months ago

What kind of intervention?

Do you mean the commit hash will in fact be updated automatically?

That was what I planned to do.

But for this specific case, the relevant repository has been inactive for years. So I think it's fine to use the commit hash only.