flathub / rocks.koreader.KOReader

https://flathub.org/apps/details/rocks.koreader.KOReader
1 stars 2 forks source link

todo: verification #34

Closed pazos closed 5 months ago

pazos commented 5 months ago

After #32, #33

Docs: https://docs.flathub.org/docs/for-app-authors/verification/

Thoughts?

@proletarius101 @Frenzie

Frenzie commented 5 months ago

Putting an extra file in https://github.com/koreader/koreader.github.io/ doesn't really seem any different than putting a release artifact on https://github.com/koreader/koreader but if that's desirable for some reason it's fine by me.

pazos commented 5 months ago

Putting an extra file in https://github.com/koreader/koreader.github.io/ doesn't really seem any different than putting a release artifact on https://github.com/koreader/koreader but if that's desirable for some reason it's fine by me.

It isn't the same. It is like F-Droid: an external store that has its own build pipeline. But fdroid default repo is centralized and there's no way to have different KOReader versions in there, while in Flathub each dev can submit an app as long as the app id differs.

Currently there's only one, backed by this repo, that has the proper app id (rocks.koreader.KOReader) and was provided as a friendly contribution. So by verifying this one we at least aknowledge it exists and meets certain criteria for publishing.

The "unverified/verified" badge is available on https://flathub.org/apps/rocks.koreader.KOReader and potentially on app stores that support flatpak.

Frenzie commented 5 months ago

It's now verified and complaining about some things. image

pazos commented 5 months ago

It's now verified and complaining about some things.

  1. Brand colors:

That's easy. https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/quality-guidelines#brand-colors

white for light mode and a dark color that's ok with the logo. Maybe https://encycolorpedia.es/303030?

  1. App icon:

https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/quality-guidelines#app-icon

square svg with more padding?

  1. Summary:

Document viewer

¿?

And adjust a bit the description. I'm not a fan of current fdroid metadata either: https://f-droid.org/en/packages/org.koreader.launcher.fdroid/

Fdroid metadata supports translations, so maybe we could come up with generic metadata for stores and pushing the changes to https://github.com/koreader/koreader/tree/master/metadata

Screenshots for fdroid are also picked from images/phoneScreenshots. We can add images/computerScreenshots and push the same content following https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/quality-guidelines#screenshots

Frenzie commented 5 months ago

Document viewer

I guess so

pazos commented 5 months ago

app icon

something like

koreader-square

??

Frenzie commented 5 months ago

I didn't check what it says about it. That's supposed to mean cutting off the corners a little like on Android? Should be fine.