search

flathub / rocks.koreader.KOReader

https://flathub.org/apps/details/rocks.koreader.KOReader
1 stars 2 forks source link

Full read-write acess #35

Closed pazos closed 5 months ago

pazos commented 5 months ago

Required by a bunch of stuff.

Fixes #32

flathubbot commented 5 months ago

Started test build 120006

flathubbot commented 5 months ago

Build 120006 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/102867/rocks.koreader.KOReader.flatpakref
flathubbot commented 5 months ago

Started test build 120026

flathubbot commented 5 months ago

Build 120026 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/102887/rocks.koreader.KOReader.flatpakref
pazos commented 5 months ago

How about only the home and the media? Users are not supposed to store files to the system directories and exposing excessive locations is a privacy risk

While I agree it isn't a primary user case it sounds like an arbitrary restriction that cripples the program behaviour without a very good reason.

Case in point (there're many):

Peek 13-05-2024 17-50

But even more relevant: Okular, another good, featureful, document viewer states this in its metadata: https://github.com/flathub/org.kde.okular

The same applies to KOReader. Arbitrary restrictions shouldn't occur.

proletarius101 commented 5 months ago

OK, I think it should be fine then

flathubbot commented 5 months ago

Started test build 120673

flathubbot commented 5 months ago

Build 120673 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/103532/rocks.koreader.KOReader.flatpakref
pazos commented 5 months ago

Also related: --filesystem=xdg-run/gvfs is required in order to use virtual filesystems (such as mtp, smb or gdrive).

For instance: Peek 14-05-2024 01-15

Is going to fail until the permission is specified, if I understood correctly from https://docs.flatpak.org/en/latest/sandbox-permissions.html

I was under the impression that requesting full filesystem permission was enough to read /run/user/$(id), but it seems that's not the case. I didn't test yet.

Do note that KOReader is a legacy app that works with real files on the filesystem. We can't use xdg-desktop-portal and we won't do gio or dbus.

pazos commented 5 months ago

Just tested:

https://github.com/flathub/rocks.koreader.KOReader/pull/35#issuecomment-2108087669 still fails because /usr isn't allowed unless we use host-os on the manifest.

Still a limitation compared to the full blown app, but a minor one compared to the gvfs/fuse thing.