flathub / sh.ppy.osu

https://flathub.org/apps/details/sh.ppy.osu
MIT License
25 stars 13 forks source link

Created the svg icons to replace the old png one #134

Closed Viliansh closed 8 months ago

Viliansh commented 8 months ago

They are not perfect tho, i fixed some of the issues when converting it to svg, and i can understand if not wanting to merge because of that, also in the last commit i removed the png and their yaml entries, if wanted, i could just drop the last commit and keep the old png icons(for fallback maybe)

flathubbot commented 8 months ago

Started test build 80678

flathubbot commented 8 months ago

Build 80678 failed

flathubbot commented 8 months ago

Started test build 80680

flathubbot commented 8 months ago

Build 80680 failed

flathubbot commented 8 months ago

Started test build 80704

flathubbot commented 8 months ago

Build 80704 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/63333/sh.ppy.osu.flatpakref
peppy commented 8 months ago

@Vilianexe Thanks for your contribution. Honestly, I'd need to go and find the originals we have and see if they are already vector. If not, any recreation may be helpful for future efforts.

That said, I think you'd be better off PRing these changes to the osu! repo directly (https://github.com/ppy/osu), likely putting the files in https://github.com/ppy/osu/tree/master/assets. I'm pretty sure we already have an official version of the osu!/lazer logo in vector, or figma, too.

Viliansh commented 8 months ago

I'd need to go and find the originals we have and see if they are already vector. If not, any recreation may be helpful for future efforts.

that could be better, or the original raw file, because the conversion leave very subtle bugs, and it create a ton of .svg elements, so when opening it and trying to edit it's messy

That said, I think you'd be better off PRing these changes to the osu! repo directly

okay!, if you find the originals i could update it on the PR

I'm pretty sure we already have an official version of the osu!/lazer logo in vector, or figma, too.

Could you send me where it's?, i couldn't find it on the official repo, only the .ico