flathub / sh.ppy.osu

https://flathub.org/apps/details/sh.ppy.osu
MIT License
25 stars 13 forks source link

Udev script and instructions are out of date. #167

Open jamesbt365 opened 3 months ago

jamesbt365 commented 3 months ago

The udev script provided doesn't match the current udev format or file location.

In recent times our udev script has changed also no longer relies on dotnet (the README of this repo mentions that it does still)

The dependencies for the script are now: git jq tr awk sed, which is better than the full fat dotnet sdk, so its probably advisable to either adapt this script or use it.

I understand that the official script provides less choices (like the ability to reload rules after installing them or uninstalling rules) but the process for generating rules is much cleaner now and it no longer generates duplicate rules. Alongside being named 70-opentabletdriver.rules instead.

Its also worth mentioning that these instructions alone are not usually enough to get the tablet running with lazer, the udev rules can prevent the kernel drivers from latching onto the tablet but its usually not enough and unloading hid_uclogic is required for all non wacom tablets.

I'm not sure if the wacom module messes with device descriptors (hid_uclogic does, and thus must be unloaded) and I'm not sure of the input pipeline in lazer but OTD might be able to block the input from the wacom module while the game is in focus.

However, its a bit tricky here as blacklisting these modules (preventing them from loading entirely) will prevent the tablet from working outside the game unless full fat OTD or another driver is running. Not sure how you really want to handle that, or if you just want to put a note of it, but currently the setup instructions for tablets could be improved.