search

flathub / sh.ppy.osu

https://flathub.org/apps/details/sh.ppy.osu
MIT License
25 stars 13 forks source link

fix vulkan renderer initialization by symlinking libdl to /app/bin #171

Closed jaydns closed 3 months ago

jaydns commented 3 months ago

when the "vulkan (experimental)" renderer is selected, it tries looking for libdl.so in /app/bin/ but it only exists in /usr/lib/x86_64-linux-gnu/. adding a symlink fixes this issue image

flathubbot commented 3 months ago

Started test build 114395

flathubbot commented 3 months ago

Build 114395 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/97207/sh.ppy.osu.flatpakref
peppy commented 3 months ago

cc @smoogipoo not sure if we want to do this here.

smoogipoo commented 3 months ago

I think we definitely don't want to do this. Everything should work fine if we use libdl.so.2, which is already relied on by ourselves (and other places) and Veldrid, and more.

In this case, the failing library is not one we own.

But the true solution is to not implement this in the first place, and use NativeLibrary instead. The failing library in question targets netstandard1.4 which didn't have this.

I'm fine with Vulkan being broken here for the time being - it's broken for a majority of users in other ways anyway.

smoogipoo commented 3 months ago

We are going to be fixing this ourselves, starting with https://github.com/ppy/vk/pull/1