search

flathub / sh.ppy.osu

https://flathub.org/apps/details/sh.ppy.osu
MIT License
26 stars 14 forks source link

Use SDL2 from shared-modules for better Wayland compat, use Wayland b… #90

Closed orowith2os closed 1 year ago

orowith2os commented 1 year ago

…y default

Several external sources suggest using native Wayland, and as manually shipping SDL2 can fix up issues there were before, defaulting to Wayland shouldn't be an issue.

Supersedes https://github.com/flathub/sh.ppy.osu/pull/37

flathubbot commented 1 year ago

Started test build 15297

flathubbot commented 1 year ago

Build 15297 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/127716/sh.ppy.osu.flatpakref
flathubbot commented 1 year ago

Started test build 62137

orowith2os commented 1 year ago

@peppy can you take a look at this? Dealing with Wayland needs to be done sooner or later, and upstream SDL already defaults to it, so you're kinda forced into it somewhere. Fd.o 23.08 is probably going to contain a new enough SDL that defaults to Wayland, so better nab it.

flathubbot commented 1 year ago

Build 62137 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/44770/sh.ppy.osu.flatpakref
peppy commented 1 year ago

We build our own SDL2 with our own requirements.

I don't foresee this ever being a valid direction as we would get an influx of users reporting whatever issues against random SDL versions.