search

flathub / shared-modules

Common Flatpak modules that can be used as a git submodule
111 stars 88 forks source link

Add libnotify #262

Closed bbhtt closed 1 year ago

bbhtt commented 1 year ago

Closes https://github.com/flathub/shared-modules/issues/234

Draft because waiting on https://gitlab.com/freedesktop-sdk/freedesktop-sdk/-/issues/1642

I kept the x-checker because it makes easier to update and in the future shared-modules might get a x-checker workflow.

hfiguiere commented 1 year ago

you should add yourself to the maintainers for that module. That's the commitment when you submit it.

hfiguiere commented 1 year ago

See CODEOWNERS

bbhtt commented 1 year ago

Ah thanks forgot about that

orowith2os commented 1 year ago

If the runtime gets libnotify (even if not in 23.08) it would probably make sense to close this in favor of waiting until 24.08. So keep that in mind - 30-40 apps shipping this manually isn't a big deal if it means they can strip it later.

Erick555 commented 1 year ago

If libnotify would be in fsdk 24.08 then it may be not worth adding it here for just one year.

bbhtt commented 1 year ago

Yea this is incase if it doesn't get accepted into the runtime. I'll close if it gets in.

bbhtt commented 1 year ago

It was added to the SDK/runtime. If everything goes well, it'll be in 24.08 I think. So closing.