search

flathub / tv.kodi.Kodi

https://flathub.org/apps/details/tv.kodi.Kodi
GNU Lesser General Public License v2.1
23 stars 23 forks source link

Add PipeWire support #241

Closed neo1973 closed 2 months ago

neo1973 commented 2 months ago

The -DENABLE_PIPEWIRE=ON is optional as PipeWire is already build but I guess it doesn't hurt.

Fixes #240.

flathubbot commented 2 months ago

Started test build 113926

flathubbot commented 2 months ago

Build 113926 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/96737/tv.kodi.Kodi.flatpakref
razzeee commented 2 months ago

bot, build

flathubbot commented 2 months ago

Queued test build for tv.kodi.Kodi.

flathubbot commented 2 months ago

Started test build 114502

flathubbot commented 2 months ago

Build 114502 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/97315/tv.kodi.Kodi.flatpakref
flathubbot commented 2 months ago

Started test build 114539

flathubbot commented 2 months ago

Build 114539 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/97352/tv.kodi.Kodi.flatpakref
razzeee commented 2 months ago

Thanks!

razzeee commented 1 month ago

@neo1973 I will revert this for now

Jusix commented 1 month ago

@razzeee Why the hell was this reverted? Now my kodi setup is broken again.

razzeee commented 1 month ago

Cause it broke every ubuntu setup

Jusix commented 1 month ago

@razzeee That's not true. I'm using a Ubuntu setup and for me it's broken without this...

razzeee commented 1 month ago

Probably not 22.04. lts then

Jusix commented 1 month ago

Yes I have Ubuntu 24.04 with PipeWire only and no PulseAudio installed. But removing a valid permission from kodi as a workaround to handle bad sound setups seems like a really bad fix to me.

razzeee commented 1 month ago

It should still work fine, as it did work fine before this change. Maybe your settings specify pipewire somewhere, pipewire itself emulates pulse.

Jusix commented 1 month ago

No it's broken now and it was broken before this commit. My sound setup is clean as it should be. Only native pipewire and no pipewire-pulse installed. Why should I install another emulation layer like pulse when kodi has native pipewire support, that doesn't make sense.

Erick555 commented 1 month ago

Kodi didn't handle very well mixed pulse/pipewire setup and the fix isn't in stable release yet so revert was unfortunate but necessary decision. You may just set --filesystem=xdg-run/pipewire-0 yourself and move on. When kodi is fixed then pipewire support can be re-added again.