search

flathub / us.zoom.Zoom

https://flathub.org/apps/details/us.zoom.Zoom
36 stars 47 forks source link

zoom.sh: Lie to Zoom about the desktop in Wayland #338

Closed Conan-Kudo closed 2 years ago

Conan-Kudo commented 2 years ago

Zoom employs a check for Wayland screensharing to only allow it when it detects that GNOME is the running desktop. However, since Zoom 5.11.0, Wayland screensharing is done through the XDG desktop portal mechanism, and thus is desktop independent.

Unfortunately, the check is still in place, and in order to allow Wayland screen sharing to work on KDE Plasma and other Wayland environments, we need to lie to Zoom to allow it through.

Thus, we set XDG_CURRENT_DESKTOP to "gnome" whenever we detect we are running Zoom in a Wayland environment to satisfy the check.

Fixes #307

flathubbot commented 2 years ago

Started test build 97113

flathubbot commented 2 years ago

Build 97113 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/94841/us.zoom.Zoom.flatpakref
TheEvilSkeleton commented 2 years ago

@Conan-Kudo can you edit your comment and add Closes #307? Your MR solves issue #307.

Conan-Kudo commented 2 years ago

Done.

flathubbot commented 2 years ago

Started test build 97168

flathubbot commented 2 years ago

Build 97168 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/94896/us.zoom.Zoom.flatpakref
nedrichards commented 2 years ago

Yep, I think this is good to take with the 5.11 series. I can see a few potential downsides but being able to screenshare is a big enough plus for those users.