flathub / us.zoom.Zoom

https://flathub.org/apps/details/us.zoom.Zoom
35 stars 45 forks source link

Drop kde own name #416

Open bbhtt opened 11 months ago

flathubbot commented 11 months ago

Started test build 69288

flathubbot commented 11 months ago

Build 69288 failed

flathubbot commented 11 months ago

Started test build 69289

flathubbot commented 11 months ago

Build 69289 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/51944/us.zoom.Zoom.flatpakref
bbhtt commented 11 months ago

I don't have a zoom account to test, please test this before merging. There's no way to trigger tray when logged out as far as I can see.

takluyver commented 10 months ago

I've just tested this on Gnome (44.5 on Fedora 38). I didn't install this branch, but I removed the 'session bus owns' org.kde.* entry in Flatseal, which should be equivalent.

The status icon shows up, but the context menu breaks. With the 'owns' permission enabled, right or left clicking shows a Gnome-style menu nicely lined up with the icon: Screenshot from 2023-10-11 15-32-17

Without this permission, left clicking activates the Zoom main window directly, and right clicking opens a non-styled menu in the top-left of my screen (not aligned with the status icon):

image

(The language difference is me messing with Zoom's own settings, not affected by this)

So I think it's best to leave this permission in place for the time being.

bbhtt commented 10 months ago

but I removed the 'session bus owns' org.kde.* entry in Flatseal, which should be equivalent.

I think --talk-name=org.kde.StatusNotifierWatcher will fix that, which this PR does too

takluyver commented 10 months ago

My bad, I should have checked more carefully. However, when I make both changes in Flatseal, the status tray icon doesn't show up at all. :confused:

bbhtt commented 10 months ago

Ok, I see the issue, it is using old Qt version and still using StatusNotifierItem PID-ID thing.