search

flathub / us.zoom.Zoom

https://flathub.org/apps/details/us.zoom.Zoom
35 stars 44 forks source link

Use html for krb5 update check #430

Closed der-eismann closed 6 months ago

der-eismann commented 6 months ago

The issue is that Anitya stores the -final suffix, so $version can't be used. But there's also not always a $patch, so there would never be PRs for patch updates. With the HTML data checker this works correctly.

INFO    src.manifest: Checking 2 external data items
INFO    src.manifest: Started check [1/2] archive krb5/krb5-1.21.tar.gz (from us.zoom.Zoom.json)
INFO    src.manifest: Skipped check [2/2] archive zoom/zoom.tar.xz (from us.zoom.Zoom.json)
INFO    src.lib.externaldata: Source krb5-1.21.tar.gz: got new version 1.21.2
INFO    src.manifest: Finished check [2/2] archive krb5/krb5-1.21.tar.gz (from us.zoom.Zoom.json)
OUTDATED: krb5-1.21.tar.gz
 Has a new version:
  URL:       https://kerberos.org/dist/krb5/1.21/krb5-1.21.2.tar.gz
  MD5:       97d5f3a48235c53f6d537c877290d2af
  SHA1:      b88e9f819974a82d156654dccbd5ee3d1de8a98e
  SHA256:    9560941a9d843c0243a71b17a7ac6fe31c7cebb5bce3983db79e52ae7e850491
  SHA512:    4e09296b412383d53872661718dbfaa90201e0d85f69db48e57a8d4bd73c95a90c7ec7b6f0f325f6bc967f8d203b256b071c0191facf080aca0e2caec5d0ac49
  Size:      8622513
  Version:   1.21.2
  Timestamp: 2023-08-15 05:47:15

INFO    src.main: Check finished with 0 error(s)
flathubbot commented 6 months ago

Started test build 91532

flathubbot commented 6 months ago

Build 91532 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/74216/us.zoom.Zoom.flatpakref
muelli commented 6 months ago

thanks for the patch!

I've quickly browsed the flathub packages for krb5: https://github.com/search?q=org%3Aflathub%20krb5&type=code and it seems that many different versions are used.

Would you mind proposing krb5 for the shared modules? https://github.com/flathub/shared-modules Then we can port krb5 users to the common version and reduce maintenance efforts.

muelli commented 6 months ago

I also wonder whether we should inform release-monitoring.org people about the problem...

flathubbot commented 6 months ago

Started test build 91639

flathubbot commented 6 months ago

Build 91639 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/74323/us.zoom.Zoom.flatpakref
der-eismann commented 6 months ago

I also wonder whether we should inform release-monitoring.org people about the problem...

They do kinda know, see https://github.com/fedora-infra/anitya/issues/259. It could be changed to a custom backend as suggested, but I think the chance of running into GitHub's rate limit are higher then.

But the point with the shared modules is very good, I'll see what I can do. Thanks for merging!