search

flathub / us.zoom.Zoom

https://flathub.org/apps/details/us.zoom.Zoom
35 stars 46 forks source link

Wrap ZoomWebviewHost executable with zypak instead of zoom #475

Closed takluyver closed 4 weeks ago

takluyver commented 4 weeks ago

Since 6.1, I've been getting messages 'It looks like "ZoomWebviewHost" crashed...", although the functionality I use still works. I finally got round to digging into this, and it looks like zoom's embedded chromium now has a separate executable, so that ZoomWebviewHost needs to be wrapped with Zypak instead of the main zoom executable.

I'm hoping this will also fix #473.

flathubbot commented 4 weeks ago

Started test build 140360

flathubbot commented 4 weeks ago

Build 140360 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/123400/us.zoom.Zoom.flatpakref
takluyver commented 4 weeks ago

This does get rid of the crash messages, and the 'Loading...' spinner in the sidebar, but now the screensharing options (which were just fixed in #474) seem to be gone again. I'll try to figure out what's going on, but at least for me screensharing is more important than the sidebar, so I'd rather this not be merged as it is.

flathubbot commented 4 weeks ago

Started test build 140365

flathubbot commented 4 weeks ago

Build 140365 successful To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/123405/us.zoom.Zoom.flatpakref
takluyver commented 4 weeks ago

Yup, screen sharing options are back, it was an obvious oversight when I changed the install commands.

crepererum commented 4 weeks ago

I've tested https://github.com/flathub/us.zoom.Zoom/pull/475#issuecomment-2290931960 :

  1. screen sharing works
  2. the spinner and the crash message mentioned in #473 are gone BUT the side bar and basically all views that (I think) use the webview (sidebar, calendar, notes, schedule, ...) are just blank/white.
takluyver commented 4 weeks ago

Thanks!

I'm guessing all of these webview things are also broken at the moment, i.e. this PR doesn't break anything that currently works? I don't use any of these features, and I don't even know where to find some of them. :wink:

crepererum commented 4 weeks ago

I'm guessing all of these webview things are also broken at the moment, i.e. this PR doesn't break anything that currently works?

I think this is correct, but somebody else may double-check.

I don't use any of these features, and I don't even know where to find some of them.

The only feature I really use is to see a list of upcoming meetings, esp. if you dismissed the somewhat annoying overlay notification that Zoom has and then want to find the meeting link again.

takluyver commented 4 weeks ago

Thanks! So all of the ones I can find on the main screen (calendar sidebar, notes, whiteboards, meetings, clips) do seem to be stuck with a spinner in master:

image

Whereas in this branch the spinner appears briefly and then they go blank. Given the lack of a crash, I suspect this is one step closer to working, but it's clearly not fully working.

nedrichards commented 4 weeks ago

Before it was crashing we had the same 'webviews are blank' issue. Agreed that stopping things crashing is better than not. There is obviously a tottering tower of fragility here but this isn't exactly hard to revert if needed, or work out what needs to point to what.

takluyver commented 4 weeks ago

Thanks!

On Thu, 15 Aug 2024, 19:53 Nick Richards, @.***> wrote:

Merged #475 https://github.com/flathub/us.zoom.Zoom/pull/475 into master.

— Reply to this email directly, view it on GitHub https://github.com/flathub/us.zoom.Zoom/pull/475#event-13900891842, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACQB5ML5GBYIUKOQ5AXUE3ZRT2IZAVCNFSM6AAAAABMRYTKXCVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTHEYDAOBZGE4DIMQ . You are receiving this because you authored the thread.Message ID: @.***>