search

flathub / xyz.rescribe.rescribe

https://flathub.org/apps/details/xyz.rescribe.rescribe
0 stars 1 forks source link

Missing window controls #5

Open maymage opened 1 year ago

maymage commented 1 year ago

This is how Rescribe looks like on my Fedora 38, GNOME 44 machine

image

This is with the current version

flatpak info xyz.rescribe.rescribe 

Rescribe - High quality OCR for images, PDFs and Google Books.

         Kennung: xyz.rescribe.rescribe
             Ref: app/xyz.rescribe.rescribe/x86_64/stable
     Architektur: x86_64
           Zweig: stable
         Version: 1.1.0
          Lizenz: GPL-3.0
        Ursprung: flathub
        Sammlung: org.flathub.Stable
    Installation: system
     Installiert: 194,6 MB
Laufzeitumgebung: org.freedesktop.Platform/x86_64/22.08
             Sdk: org.freedesktop.Sdk/x86_64/22.08

          Commit: 583d051d751e3a8e332528a299fcc6186762e4fc99121700…
          Parent: be08c6d75d763928eb4b494b95517b51e8511bf891370f7b…
         Betreff: Build wayland and x11 versions and use launcher script to choose the appropriate one (567859ef)
           Datum: 2023-02-14 14:12:14 +0000
nickjwhite commented 8 months ago

Hi @maymage, I'm so sorry I left this issue for so long!

It has been a very long time since I've used Gnome (I use Sway myself), so I missed that the window decorations were missing - thanks so much for your report. I looked into window decoration support in the GUI toolkit we use (fyne), and it looks like the next version (2.5.0) will properly support decorations, thanks to this commit. I'll make a new flatpak release of rescribe updating to this once it's out and stable, and will keep this ticket open until then.

Thanks again for reporting this!

Jacalz commented 7 months ago

I just want to chime in on this. Wayland support is, as of Fyne v2.4.x, considered not fully supported and I would strongly advice against using the Wayland support as it currently stands. The users will get a lot better support with the X11 backend. However, this will hopefully not be the case with v2.5.0 once that releases. The PR mentioned above does improve things a lot but there are still a few minor hiccups left to solve (mostly scaling).

nickjwhite commented 7 months ago

Hi @Jacalz, thanks for chiming in. I use wayland myself, and my experience with the Fyne wayland support is that it's perfectly good for Rescribe (with the exception of this issue), and the scaling is perfect, unlike X11 on Wayland. So I'll stick with Wayland unless I get reports of stuff not working for people. The flatpak package does actually include X11 and Wayland builds, and uses a little launcher script to decide which to execute based on what environment it's in (see line 27).

Jacalz commented 7 months ago

Alright. I'm glad that you find it to be working well. Nice idea with the script to launch the right binary. I might want to do something similar for https://github.com/Jacalz/rymdport/issues/122.

I'll talk to the rest of the Fyne team if we should consider backporting https://github.com/fyne-io/fyne/pull/4481 and https://github.com/fyne-io/fyne/pull/4704 for the new versions of GLFW with better Wayland support. I can't guarantee anything but I'll see what they have to say.

Jacalz commented 7 months ago

Another thing worth noting: I'm glad to see another Fyne application on Flatpak and Flathub. I regret not knowing about this one when doing the first talk in https://m.youtube.com/watch?v=EsX8CgC_N5M&pp=ygUNZnluZWNvbmYgMjAyMw%3D%3D.

Feel free to reach out if you find any problems with Flatpak, Wayland support or any other issues. Things should be a lot nicer with https://github.com/fyne-io/fyne/pull/4406 in v2.5.0 anyway.

nickjwhite commented 6 months ago

Yes absolutely @Jacalz, I'm really looking forward to the v2.5.0 release for the XDG Desktop Portal support and the window controlls stuff working, thanks for working on it!