ECMAScript 5.1 Array functions break IE8

flatiron / director

a tiny and isomorphic URL router for JavaScript

http://github.com/flatiron/director

MIT License

5.6k stars 486 forks source link

ECMAScript 5.1 Array functions break IE8 #270

Open jaydenseric opened 9 years ago

jaydenseric commented 9 years ago

ECMAScript 5.1 Array functions Array.isArray() and Array.prototype.filter break IE8.

To get Director working, I had to include these two polyfills earlier:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray#Polyfill
https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/filter#Polyfill

Following this, everything seems to work in IE8.

beaugunderson commented 9 years ago

I think it should be the responsibility of the environment to include any needed polyfills--but that should be documented and it is not currently! The TODO is to document this in README.md.

jaydenseric commented 9 years ago

Is the base level of browser support documented anywhere for this project? I saw some comments in the JS mentioning IE8 behaviour and from that assumed IE8 was supported.