search

flatiron / plates

Light-weight, logic-less, DSL-free, templates for all javascript environments!
MIT License
831 stars 69 forks source link

Browser tests, fix greedy matching, default data-bind, convention and configuration #105

Closed osmestad closed 8 years ago

osmestad commented 11 years ago

The first commit adds all tests to browser runner: This adds all tests in api-test.js to browser.html. I used the browser.js script to generate the skeleton of the code, then manually copy/pasted the content of the tests (I assume it has to be done this way as the IIFEs make it imposible to introspect the original test source code). The only test that needed modifying was number 33 as that doesn't use common.createTest(). (All the new tests pass, the two of the old ones that failed are still failing.)

The second commit fixes the issue described here: https://github.com/flatiron/plates/issues/65 and updates tests accordingly.

The third commit updates https://github.com/flatiron/plates/pull/58 data-bind and data-bind-(attr).

The fourth commit fixes cases where 'data-bind' would unintentionally overwrite content in a template.

The sixth commit add the (non optional) ability to use both defined mappings and default behaviour, as referred to in #73 and #76 (I think this makes more sense than current behaviour).

PS Sorry for not using feature branches for this, but one fix led to another :)

wprater commented 11 years ago

Is there any interest in merging this PR? Or is this project gaining no more support?

indexzero commented 8 years ago

Closing this due to age. This project is formally deprecated. Will be adding a notice soon.