search

flatiron / plates

Light-weight, logic-less, DSL-free, templates for all javascript environments!
MIT License
831 stars 69 forks source link

fix for attributes containing quotes like ng-include="'val'" #115

Closed 007design closed 10 years ago

007design commented 10 years ago

When using a library such as AngularJS it is possible that tag values will contain single quotes like this:

to indicate a String value rather than a variable value. The attr regex matches the first ' as the end of the attribute rather than the second ". This commit updates the regex to match the closing quote delimiter to the opening delimiter

3rd-Eden commented 10 years ago

Hi,

It seems that you change caused the build to fail. In order for this pull request to get merged it shouldn't be breaking existing tests and have tests included for the new functionality. Once this is resolved, i'll be more than happy to merge it in.

007design commented 10 years ago

I updated the vows version to 0.7 and the tests are passing.

3rd-Eden commented 10 years ago

Thanks a lot for your contribution.