search

flatiron / plates

Light-weight, logic-less, DSL-free, templates for all javascript environments!
MIT License
831 stars 69 forks source link

Test fixtures for issue #59 #60

Closed dougalcampbell closed 8 years ago

dougalcampbell commented 12 years ago

Here are my tests for issue #59, "Another nested object problem"

framp commented 12 years ago

Thanks for the fix!

After using plates for quite some time I got the same bug you described in issue #59 It's pretty easy to get caught by this one, still don't understand how I didn't manage to trigger it before!

The main problem here is that we're trying to parse HTML by using regular expressions (http://stackoverflow.com/questions/1732348/regex-match-open-tags-except-xhtml-self-contained-tags)

I'm not sure how much having a proper xml parser would impact speed, but using regex is quite bug prone in my book.

Hope this get merged up!

dougalcampbell commented 12 years ago

Yeah, even though I came up with a patch that worked for me (never did get around to making an updated pull request, though), I wasn't 100% happy with it. It seems brittle, and I keep thinking there's some other edge-case lurking in there. Glad if it helped you, though.

indexzero commented 8 years ago

Thank you for your contribution, but closing this due to age. This project is formally deprecated. Will be adding a notice soon.