Multimap - Githubissues

pgte commented 12 years ago

Several fixes related to mapping the same attribute name and value, using collections and nesting.

Fixed the case where to mappings for the same attribute and value existed where one changed the tag content and the other updated the attribute. In this case, only when the attribute one was declared last it worked. Changing the order of the declarations made it work. The fix orders the mappings so that the order of the declaration doesn't matter.
Testing if there are conflicting mappings (updating the body for the same attribute and same value).
Nested objects work with map directives.
Arrays now work with map directives.
Added test for two attributes update on the same tag.
Added test for two attributes update plus body update on the same tag.

Added test cases for all these fixes.

travisbot commented 12 years ago

This pull request passes (merged 4620d18a into bee4f18e).

3rd-Eden commented 12 years ago

This is gonna clash so hard with my branch :p

pgte commented 12 years ago

Because of the test case numeration, right? I can do the merge, the changes were pretty simple. :)

3rd-Eden commented 12 years ago

yes, mainly due to the test numeration.

heapwolf commented 12 years ago

@pgte any change you can take a look at @3rd-Eden's branch and see what can be done to make sure that we get as little clashing as possible?

heapwolf commented 12 years ago

@pgte I think it will be easier to re-factor this with @3rd-Eden's branch now merged.

pgte commented 12 years ago

@hij1nx will do.

pgte commented 12 years ago

Going to do another PR from a diff branch.

flatiron / plates