flatiron / plates

Light-weight, logic-less, DSL-free, templates for all javascript environments!
MIT License
831 stars 69 forks source link

Multimap remastered #83

Closed pgte closed 12 years ago

pgte commented 12 years ago

@hij1nx and @3rd-Eden, I need your input on this:

There is only one issue with the merge, and it's related with my fix.

Test 14 and 15 also test for nesting, but when the inner iteration starts the nesting is not done using the "mapping" mode.

Yours: https://github.com/flatiron/plates/blob/master/test/api-test.js#L149 Mine: https://github.com/pgte/plates/blob/multimap-remastered/test/api-test.js#L150

The fix I did reuses the mapping inside each iteration, which I think is correct, but for these cases activate the mapping mode, and the user has to input the missing mappings.

travisbot commented 12 years ago

This pull request passes (merged b0515b8b into 5450c28f).

pgte commented 12 years ago

The fixes on PR 81 are still valid:


Several fixes related to mapping the same attribute name and value, using collections and nesting.