search

flatiron / plates

Light-weight, logic-less, DSL-free, templates for all javascript environments!
MIT License
831 stars 69 forks source link

Fixed #84 - properly matching closing tags when iterating #85

Closed pgte closed 12 years ago

pgte commented 12 years ago

The match was being made to the last found closing tag, which is wrong. Matching tag count is now performed, and an error is thrown if the tags cannot be matched.

travisbot commented 12 years ago

This pull request passes (merged 149c9fa0 into 34c73bc3).

3rd-Eden commented 12 years ago

LGTM, it doesn't freak out with self closing elements right? Such as <input> without a \ etc

pgte commented 12 years ago

Before it used the html.lastIndexOf(tag), which also doesn't work for self-closing tags. Maybe create a new ticket for this?

3rd-Eden commented 12 years ago

I don't know if it's a serious issue or not, there haven't been any reports against it but it might still be worth to investigate that behavior.