search

flatironinstitute / CaImAn-MATLAB

Complete Matlab pipeline for large scale calcium imaging data analysis
GNU General Public License v2.0
252 stars 147 forks source link

refactoring run_CNMF_patches #61

Closed jennan closed 7 years ago

jennan commented 7 years ago

Hello,

I made some changes in run_CNMF_patches to remove a little bit of code duplication. I hope you will find these changes useful.

In the process, I found some bugs, that you can reproduce with the provided test cases in tests folder. I made sure that the code is running but nothing fancier that this, and hope I didn't break anything while moving code around. Let me know if you have some ideas of easily verifiable artificial test cases :-), or some standard test cases with known results I should check against.

epnev commented 7 years ago

Hi @jennan This looks beautiful. Thanks a lot for the contribution!