flatironinstitute / CaImAn

Computational toolbox for large scale Calcium Imaging Analysis, including movie handling, motion correction, source extraction, spike deconvolution and result visualization.
https://caiman.readthedocs.io
GNU General Public License v2.0
640 stars 370 forks source link

Pims fallback for avi loading #1161

Closed EricThomson closed 1 year ago

EricThomson commented 1 year ago

Description

This should fix the problems with loading avi in Windows. It cleans up the logic of the pims fallback branch (thanks Pat), and I worked on the subindixing bits in pims, which was also neglected. Main change is fix to caiman_.base.movies.load() and .load_iter() methods (the later is used in online methods)

Fixes #1137 #883

Type of change

Introduces no new problems with tests.

Ran tests in pims_load_testing.py

Now the cnmfe online demo notebook runs (demo_online_cnmfE.ipynb). It would be good if someone tests on linux/mac.