What is cufiNUFFT using streams for at the moment

flatironinstitute / cufinufft

Nonuniform fast Fourier transforms of types 1 and 2, in 1D, 2D, and 3D, on the GPU

Other

83 stars 18 forks source link

What is cufiNUFFT using streams for at the moment #117

Closed JBlaschke closed 2 years ago

JBlaschke commented 2 years ago

While researching https://github.com/dfm/jax-finufft/pull/4#issuecomment-974480880 I came across: https://github.com/flatironinstitute/cufinufft/blob/a8c979e6e70a5303a4384b01a71c86c973a79696/src/memtransfer_wrapper.cu#L88, and was wondering what cufiNUFFT is using streams for. I searched from streams and couldn't find any places where this is used, so is this WIP?

MelodyShih commented 2 years ago

Hi Johannes, no, this is not WIP and the lines of codes can be removed. The streams were created in an experiment of accelerating computations when we have multiple data with same locations of NUpts.

JBlaschke commented 2 years ago

Right! Thanks for the info. I will pick up https://github.com/flatironinstitute/cufinufft/pull/99 again, and move the stream descriptor into a struct that also sores device and context.