search

flatironinstitute / cufinufft

Nonuniform fast Fourier transforms of types 1 and 2, in 1D, 2D, and 3D, on the GPU
Other
83 stars 18 forks source link

Pass/fail checks for tests #135

Closed janden closed 1 year ago

janden commented 2 years ago

Following #125/#134, we run make check as part of the CI, but this is simply a smoke test -- no verification of results is done. It would be good to check the results (for accuracy), have the tests return a non-zero exit code if something's wrong, and have the tests fail in CI.

janden commented 1 year ago

So looks like @blackwer has already taken care of this in the finufft repo, see:

https://github.com/flatironinstitute/finufft/blob/8792a744a7473ab0ecc6e7eb5929ae17adc4df76/test/cuda/CMakeLists.txt#L81

and

https://github.com/flatironinstitute/finufft/blob/8792a744a7473ab0ecc6e7eb5929ae17adc4df76/test/cuda/cufinufft2d_test.cu#L198