search

flatironinstitute / dendro-old

Analyze neuroscience data in the cloud
https://flatironinstitute.github.io/dendro-docs/
Apache License 2.0
19 stars 2 forks source link

Use monitoring processes #108

Closed magland closed 11 months ago

magland commented 11 months ago

Use detached monitoring processes in the container for console output, resource utilization, and status checks, so that the parent job process does not run the risk of hanging on one of these tasks.

codecov-commenter commented 11 months ago

Codecov Report

Attention: 225 lines in your changes are missing coverage. Please review.

Comparison is base (54080a4) 74.79% compared to head (54f9219) 70.91%.

Files Patch % Lines
...nal_job_monitoring/resource_utilization_monitor.py 0.00% 66 Missing :warning:
.../internal_job_monitoring/console_output_monitor.py 0.00% 57 Missing :warning:
...ndro/internal_job_monitoring/job_status_monitor.py 0.00% 49 Missing :warning:
python/dendro/sdk/_run_job_parent_process.py 69.38% 30 Missing :warning:
python/dendro/internal_job_monitoring/common.py 0.00% 13 Missing :warning:
python/dendro/cli.py 33.33% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #108 +/- ## ========================================== - Coverage 74.79% 70.91% -3.88% ========================================== Files 69 72 +3 Lines 4288 4312 +24 ========================================== - Hits 3207 3058 -149 - Misses 1081 1254 +173 ``` | [Flag](https://app.codecov.io/gh/flatironinstitute/dendro/pull/108/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flatironinstitute) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/flatironinstitute/dendro/pull/108/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flatironinstitute) | `70.91% <24.49%> (-3.88%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flatironinstitute#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.