search

flatironinstitute / dendro-old

Analyze neuroscience data in the cloud
https://flatironinstitute.github.io/dendro-docs/
Apache License 2.0
19 stars 2 forks source link

upload final console output #117

Closed magland closed 8 months ago

magland commented 8 months ago

From slack Luiz: for some reason, when the job fails locally, the controller stops updating the output with the latest info, which includes the erro track etc

Jeremy: i know what's happening. In order to make the system more robust, I separated the console output monitor and the resource utilization monitors into separate processes. When the child job process fails (or finishes), the parent process exits, and then the container is closed before the console monitor has a chance to send final console output to dendro.

So I just need to put in a final upload of console output at the end, controlled by the parent process

magland commented 8 months ago

@luiztauffer This should fix it, but it won't take effect until it is pushed to pypi, and the app image is rebuilt with the updated version.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (0508d2f) 70.42% compared to head (d95532e) 71.05%. Report is 10 commits behind head on main.

Files Patch % Lines
...thon/dendro/api_helpers/routers/gui/find_routes.py 57.69% 11 Missing :warning:
python/dendro/api_helpers/clients/db.py 12.50% 7 Missing :warning:
.../internal_job_monitoring/console_output_monitor.py 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #117 +/- ## ========================================== + Coverage 70.42% 71.05% +0.62% ========================================== Files 72 73 +1 Lines 4362 4405 +43 ========================================== + Hits 3072 3130 +58 + Misses 1290 1275 -15 ``` | [Flag](https://app.codecov.io/gh/flatironinstitute/dendro/pull/117/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flatironinstitute) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/flatironinstitute/dendro/pull/117/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flatironinstitute) | `71.05% <54.54%> (+0.62%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flatironinstitute#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.