flatironinstitute / dendro-old

Analyze neuroscience data in the cloud
https://flatironinstitute.github.io/dendro-docs/
Apache License 2.0
19 stars 2 forks source link

VPC and Security Group #118

Closed luiztauffer closed 8 months ago

luiztauffer commented 8 months ago
codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (21d4103) 71.18% compared to head (a0ca175) 71.18%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #118 +/- ## ======================================= Coverage 71.18% 71.18% ======================================= Files 73 73 Lines 4435 4435 ======================================= Hits 3157 3157 Misses 1278 1278 ``` | [Flag](https://app.codecov.io/gh/flatironinstitute/dendro/pull/118/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flatironinstitute) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/flatironinstitute/dendro/pull/118/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flatironinstitute) | `71.18% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=flatironinstitute#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

magland commented 8 months ago

This looks good to me, but just one question...

with the non-default vpc, are we going to get charged for the NAT Gateway again? I remember there were 2 components for that charge -- (a) the uptime, and (b) the network traffic processed.

luiztauffer commented 8 months ago

@magland we don't need a nat gateway here, since the VPC has only public subnets. I believe before we were trying to set this up with a private VPC