flatironinstitute / dendro-old

Analyze neuroscience data in the cloud
https://flatironinstitute.github.io/dendro-docs/
Apache License 2.0
19 stars 2 forks source link

Refactor compute resource - Do not require CR restart #61

Closed magland closed 1 year ago

magland commented 1 year ago

@luiztauffer

Here I refactored the compute resource daemon in order to implement the scheme where we do not need to restart the compute resource for changes in the app configuration (from the frontend) to take effect.

Separated out the daemon into 3 classes: Daemon, AppManager, and JobManager

When the apps are changed in the frontend, a pubsub message is sent, and that's when the app manager knows to reload the apps.

TODO: reset the slurm job handler when an app is reloaded.

magland commented 1 year ago

TODO: reset the slurm job handler when an app is reloaded.

I looked more closely at the code and it doesn't seem necessary to reset the slurm job handler when an app is reloaded.