change opts.gpu_spreadinterponly to opts.spreadinterponly so fwd-compat with a CPU such use-case

flatironinstitute / finufft

Non-uniform fast Fourier transform library of types 1,2,3 in dimensions 1,2,3

Other

303 stars 79 forks source link

change opts.gpu_spreadinterponly to opts.spreadinterponly so fwd-compat with a CPU such use-case #572

Closed ahbarnett closed 1 month ago

ahbarnett commented 1 month ago

to do before 2.4

[ ] add opt to finufft.fh <- was meaningless since not finufft_opts we're proposing to change! Was cufinufft_opts.

ahbarnett commented 1 month ago

@chaithyagr We were wondering if you need this opt on CPU too? If so, we should change its name and implement smae logic for CPU.... (before 2.4 release, so we don't have to change the opt name later...) what do you think?

chaithyagr commented 1 month ago

I agree with you, while i can do it, I'm afraid I'm not free at the moment to handle it immediately.

ahbarnett commented 1 month ago

It's ok. I realised that since cufinufft_opts is still distinct from finufft_opts, there is no need to change the name. Closing.